Skip to content

Partial #6153 #4463 : reduce ipython_genutils usage #6214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 6.4.x
Choose a base branch
from
Open

Partial #6153 #4463 : reduce ipython_genutils usage #6214

wants to merge 3 commits into from

Conversation

@penguinolog
Copy link
Contributor

@penguinolog penguinolog commented Oct 25, 2021

  • remove stdlib code can be used directly or helper redundant:
      * str is already unicode
      * type casting is done in external lib
      * import aliases
  • remove unused imports
  • reduce amount of deprecated code:
    • u prefix for strings
    • Logger.warn

@penguinolog
Python compatibility: drop u string prefix as deprecated
bc6a327 
`u` prefix was used in python 2, before all strings became unicode
@penguinolog
Partial jupyter#6153 jupyter#4463 : reduce ipython_genutils usage
1cc25e1 
* remove stdlib code can be used directly or helper redundant:
  * str is already unicode
  * type casting is done in external lib
  * import aliases
* remove unused imports
@penguinolog
Logger.warn is deprecated for a while
67420fc
@penguinolog
Copy link
Contributor Author

penguinolog commented Oct 25, 2021

(macos, 3.6) CI is configured incorrectly (CI issue)

@penguinolog
Copy link
Contributor Author

penguinolog commented Nov 23, 2021

In case of python 3.6 kill it's possible wider migration with less copy-paste

@penguinolog
Copy link
Contributor Author

penguinolog commented Dec 20, 2021

@kevin-bates Can I drop python 3.6 support and use more Ipython shared code?

@kevin-bates
Copy link
Member

kevin-bates commented Jan 3, 2022

Can I drop python 3.6 support and use more Ipython shared code?

I think dropping 3.6 is the right approach. Not sure what you mean by using "more ipython shared code" however. I thought this exercise was about removing ipython dependencies. Can you please provide examples of such shared code?

@penguinolog
Copy link
Contributor Author

penguinolog commented Jan 4, 2022

Can I drop python 3.6 support and use more Ipython shared code?

I think dropping 3.6 is the right approach. Not sure what you mean by using "more ipython shared code" however. I thought this exercise was about removing ipython dependencies. Can you please provide examples of such shared code?

Main final goal is dropping ipython_genutils as having problems with modern python and officially recommended to not use.
BTW it's better to make this PR again from fresh branch after #6260 due to large diff

@kevin-bates
Copy link
Member

kevin-bates commented Jan 4, 2022

Main final goal is dropping ipython_genutils as having problems with modern python and officially recommended to not use.

I agree. You had used "ipython" in a previous response when we should try to replace with native python functions and why I needed some clarification. Thank you.

BTW it's better to make this PR again from fresh branch after #6260 due to large diff

Yes, I realized that as well last night.

@Zsailer Zsailer changed the base branch from main to 6.4.x March 7, 2022 18:20
@echarles echarles added this to the 6.4 milestone Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

3 participants

@penguinolog @kevin-bates @echarles